-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous improvements to Alignment/MillePedeAlignmentAlgorithm
unit tests
#43935
Miscellaneous improvements to Alignment/MillePedeAlignmentAlgorithm
unit tests
#43935
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43935/38797
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
3dcb4a4
to
156107b
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43935/38799
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
156107b
to
b44013f
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43935/38801
|
Pull request #43935 was updated. @cmsbuild, @saumyaphor4252, @consuegs, @perrotta can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-122395/37353/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Title says it all:
ZMuMuMassConstraintParameterFinder
plugin: e868d3dAlignment/MillePedeAlignmentAlgorithm/test/ZMuMuMassConstraintParameterFinder/README.md
d8e577bZMuMuMassConstraintParameterFinder
: 3dcb4a4PR validation:
scram b runtests
runs fineIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A